sociomantic-tsunami / swarm

Asynchronous client/node framework library
Boost Software License 1.0
14 stars 26 forks source link

Add closure allocation check to CI #325

Closed mihails-strasuns-sociomantic closed 6 years ago

nemanja-boric-sociomantic commented 6 years ago

@gavin-norman-sociomantic I looked at it again and the whole stack allocation thing looks rather pointless to me here. For example, TimerFD constructor will heap allocate exception instance internally - it doesn't matter that you create it as scope t = new TimerFD, there will be GC activity anyway.

That's a pretty good point. For some reason I believed that the scope was transitive.

mihails-strasuns-sociomantic commented 6 years ago

That's a pretty good point.

Nevermind that (I deleted the comment) - old code was creating exception field separately on scope for exactly that reason. I reproduced it in last version.

mihails-strasuns-sociomantic commented 6 years ago

Updated - not WIP anymore:

mihails-strasuns-sociomantic commented 6 years ago

Ping @leandro-lucarella-sociomantic @gavin-norman-sociomantic

mihails-strasuns-sociomantic commented 6 years ago

Ping

gavin-norman-sociomantic commented 6 years ago

Ah I hadn't noticed that you'd fixed the release notes.