search

sociomantic-tsunami / swarm

Asynchronous client/node framework library
Boost Software License 1.0
14 stars 26 forks source link

Log IOError node exceptions with info level. #337

Closed nemanja-boric-sociomantic closed 6 years ago

nemanja-boric-sociomantic commented 6 years ago

If the client ever dies during the handling of the request (which is amplified by the long-living requests), IOError will be thrown in the node and it will be logged as an error. This is not an error from the node's PoV and it's logged now with an info level.

nemanja-boric-sociomantic commented 6 years ago

Yes, "amplified" ;-). It helps mainly on the live nodes, since we don't want to generate alerts for logged errors which are not errors.

nemanja-boric-sociomantic commented 6 years ago

Updated commit message.

nemanja-boric-sociomantic commented 6 years ago

(but it also helps in turtle, yes)

gavin-norman-sociomantic commented 6 years ago

Good deed of the day: help a turtle :heavy_check_mark:

nemanja-boric-sociomantic commented 6 years ago

I'll merge this tomorrow to prevent broken Travis builds after merging (due to sourceforge's outage).

gavin-norman-sociomantic commented 6 years ago

Are you saying I should merge it before then? Or that we must wait until then?

nemanja-boric-sociomantic commented 6 years ago

We should wait until then. If we merge this, the travis will trigger v4.6.x branch rebuild which will fail due to sourceforge outage, so we'll have a red branch.

nemanja-boric-sociomantic commented 6 years ago

I think we can merge this now.