sociomantic-tsunami / swarm

Asynchronous client/node framework library
Boost Software License 1.0
14 stars 26 forks source link

Remove internal deprecations. #341

Closed nemanja-boric-sociomantic closed 6 years ago

nemanja-boric-sociomantic commented 6 years ago

This PR removes references to deprecated methods in swarm from unittests, so swarm doesn't hit it's own deprecations.

gavin-norman-sociomantic commented 6 years ago

Yeah, I was going to say, why undeprecate it when we can just not call it internally. I see you updated ;)

nemanja-boric-sociomantic commented 6 years ago

Well, the protos still need to call it. However, I forgot that we can do static if on the swarm version inside protos.

gavin-norman-sociomantic commented 6 years ago

The protos need to call it because in older swarm versions it used to do something?

nemanja-boric-sociomantic commented 6 years ago

Yes, in older swarm versions, TCP_NODELAY was not turned on by default and we thought that's too much for a patch release.