search

sociomantic-tsunami / swarm

Asynchronous client/node framework library
Boost Software License 1.0
14 stars 26 forks source link

Change use of NodeItem to AddrPort in node base classes #350

Closed gavin-norman-sociomantic closed 5 years ago

gavin-norman-sociomantic commented 5 years ago

Note to reviewer: could you confirm the changes around InetAddress and AddrPort? It's quite complicated.

gavin-norman-sociomantic commented 5 years ago

(I was originally intending to replace all internal usage of NodeItem with AddrPort -- see https://github.com/sociomantic-tsunami/swarm/issues/348 -- but this is a massive undertaking, as it's used extensively in the client. This PR just updates a small section -- the node bases.)

gavin-norman-sociomantic commented 5 years ago

Blocked pending testing with proto and node repos.

gavin-norman-sociomantic commented 5 years ago

On second thoughts, I'd prefer to not address this now. We plan to completely rewrite all of the core node stuff, anyway, at some point, so it seems better to leave it alone until then.

Replaced with #354, #355.