search

sociomantic-tsunami / swarm

Asynchronous client/node framework library
Boost Software License 1.0
14 stars 26 forks source link

Add suspend unregister callback #365

Closed matthias-wende-sociomantic closed 5 years ago

matthias-wende-sociomantic commented 5 years ago

This may be used in any proto to give applications an option to remove instances of type ISuspendable when a suspendable request finishes.

gavin-norman-sociomantic commented 5 years ago

High-level question: is this an important bug fix? Our general principle with all legacy swarm code is to not change anything unless it's very important.

matthias-wende-sociomantic commented 5 years ago

That is part of the "proper" fix to the problem described in https://github.com/sociomantic-tsunami/ocean/pull/640 (i.e. applications should remove a suspendable from the list of suspendables when a request finishes rather then keeping it in the list in a undefined state). I would consider this as a bug fix feature :).

matthias-wende-sociomantic commented 5 years ago

Alright, as discussed IRL we not gonna merge this since the switch to neo is near ;).

gavin-norman-sociomantic commented 5 years ago

Oh this should have a release note too (new feature).