search

sociomantic-tsunami / swarm

Asynchronous client/node framework library
Boost Software License 1.0
14 stars 26 forks source link

Remove deprecations #393

Closed tiyash-basu-sociomantic closed 5 years ago

tiyash-basu-sociomantic commented 5 years ago

Marked #390 to be fixed in the commit titled Remove D1 tests from CI.

matthias-wende-sociomantic commented 5 years ago

Does all of this have to happen in one PR. Otherwise I'd suggest to have one PR for pure D2 migration and a succeeding cleanup PR.

gavin-norman-sociomantic commented 5 years ago

That's what I was wondering. We could have a PR for the D2 stuff, then a PR for the deprecations, say.

tiyash-basu-sociomantic commented 5 years ago

As discussed, this PR has been split into two. This PR takes care of some optimizations post-D2 migration, and removing deprecations.

ATM, it's blocked on https://github.com/sociomantic-tsunami/swarm/pull/395 to drop D1 support.

tiyash-basu-sociomantic commented 5 years ago

Rebased on the v6.x.x branch.

tiyash-basu-sociomantic commented 5 years ago

As discussed, this commit refactoring out contracts has been removed, so that invariants are still executed in non-release builds.