search

sociomantic-tsunami / swarm

Asynchronous client/node framework library
Boost Software License 1.0
14 stars 26 forks source link

Pass received data as `const(void)[]` from `EventDispatcher.receive` #397

Closed tiyash-basu-sociomantic closed 5 years ago

tiyash-basu-sociomantic commented 5 years ago

The delegate parameter of the EventDispatcher.receive() method now takes an array of const values, instead of a const array.

tiyash-basu-sociomantic commented 5 years ago

One tiny comment: could you copy some of the rationale for this change from #303 into the commit message? It's just always nice for the commit message to describe the reason for a change.

Re: testing, we'll test this thoroughly when we test *proto with the major release candidate of swarm.

Thanks for pointing out. I've added the reasoning to the commit message now.