search

sockeqwe / Instantiator

Tired of manually setup test data of Kotlin data classes or POJOs? Instantiator creates Instances of any class for you so that you can focus on writing tests instead of spending time and effort to setup test data
Apache License 2.0
60 stars 4 forks source link

feat: added support for pair and triple #1

Closed lonskiTomasz closed 2 years ago

lonskiTomasz commented 2 years ago

What was added?

Support for Pair and Triple classes.

sockeqwe commented 2 years ago

Thanks for your contribution. Looks good 👍

Could you please add the following points:

lonskiTomasz commented 2 years ago

Thanks for your contribution. Looks good 👍

Could you please add the following points:

  • Add Pair and Triple to the README.md file to the table of the supported types.
  • Add a few more tests for nullable primitives: something like this val x: Pair<Int?, ListTest.Item> = instance(). Same for Tripple.

@sockeqwe I added information to the README about new supported types and a few more tests with nullability. Please review the changes 🎉

sockeqwe commented 2 years ago

Thanks you 👍