search

sockeqwe / ParcelablePlease

Annotation Processor for generating Parcelable code
http://hannesdorfmann.com/android/ParcelablePlease
Apache License 2.0
258 stars 21 forks source link

CodeGenerator - suggestions #13

Open MFlisar opened 9 years ago

MFlisar commented 9 years ago

I would have following suggestions:

1) if I use an abstract base class, the generator should at check the base class fields for private fields as well 2) the generator could create an empty constructor 3) it could also create the import statement for @ParcelablePlease annotation

sockeqwe commented 9 years ago

Hi, thanks for your feedback: 1) private fields can not be supported because of visibility issues. However, default and public fields in classes are supported 2) I will try to do add that to the intellij plugin #15 3) That is a bug and I will fix that #14

MFlisar commented 9 years ago

1) I just meant that the generator gives an error if I use private fields in the main class. If I use them in an abstract base class, it just skips them and does not parcel them (no message, either warning no error is visible)

sockeqwe commented 9 years ago

Ah, I see... now I understand what you mean ... I will check that! Thanks for reporting!