search

sockeqwe / fragmentargs

Annotation Processor for setting arguments in android fragments
http://hannesdorfmann.com/android/fragmentargs
Apache License 2.0
1.08k stars 87 forks source link

add androidx support #103

Closed AndreasBoehm closed 6 years ago

AndreasBoehm commented 6 years ago

This PR adds androidx support and closes https://github.com/sockeqwe/fragmentargs/issues/102

To make it easier to work with support fragments, androidx fragments and framework fragments in a single project but still using NonNull and Nullable annotations we are trying to find the available Annotation Classes during processor setup. By doing so we don't need to worry about the exact fragment type while processing.

sockeqwe commented 6 years ago

Thanks. I will do some final testing and release it. Thank you so much! I owe you at least one beer 🍺

MarcinOrlowski commented 6 years ago

Bit off-topic, but is this release going to be 4.0.0 finally? I am still using your 4.0.0-SNAPSHOT from Sonatype due to features you added there, so please do the merge if that was not the former intention.

sockeqwe commented 6 years ago

4.0.0 final

Marcin Orlowski notifications@github.com schrieb am Do., 31. Mai 2018, 07:34:

Bit off-topic, but is this release going to be 4.0.0 finally? I am still using your 4.0.0-SNAPSHOT from Sonatype due to features you added there, so please do the merge if that was not the former intention.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/sockeqwe/fragmentargs/pull/103#issuecomment-393409595, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjnrkauIZsBoEM2hrgRVLLYC-06KDocks5t34DsgaJpZM4UHaII .

carvaq commented 6 years ago

Hi

We are migrating our app to AndroidX, with your current released version we get an error. When do you think you'll be able to release these changes?

Cheers

sockeqwe commented 6 years ago

I'm about to release 4.0 right now. It's just that I have a new pc an strugle a bit setting up all maven credentials for authentication and signing but should be published in the next couple of hours

carvaq commented 6 years ago

Awesome, thank you very much!

sockeqwe commented 6 years ago

It's published as 4.0.0-RC1. It just takes some more time (1-2 hours) to sync to maven central.

So should be available in a few hours to everyone. Please let me know if you face any issue. If that is not the case, I will publish a final 4.0.0 version end of next week.