sockeqwe
commented
7 years ago Thanks for reporting. Seems like a bug. I will take a look at it in first week of August.
Alex Urzhumtcev notifications@github.com schrieb am Mi., 19. Juli 2017, 10:26:
Hello, I discribed the problem on stackoverflow https://stackoverflow.com/questions/45165126/mosby-3-mvp-presenter-is-always-recreated-when-go-back-to-the-fragment-in-the first, but didn't get the response so far. So, answer my question here.
When we do popBackStack and return to the previous fragment in the back stack, the bundle in the method onViewCreated(View view, Bundle bundle) is always null due to the fact that onSaveInstanceState(Bundle outState) wasn't called before. So, when we go back, bundle is null and a presenter (and view state) is created again. How in this case we can reuse presenter and view state (and not recreate it)?
You can see a dummy example below. There is a fragment with 2 buttons. One button opens a new Fragment and another button goes to the previous one. When you go back, presenter and view states are recreated. That's not I need, but I described above why it's happenning according to the code in the library. Is there a way to ensure that we reuse presenter and view state when we go back?
`public class FirstFragment extends MvpViewStateFragment<FirstFragmentView, FirstFragmentPresenter, FirstFragmentViewState> {
public static final String TAG = "TAG";
private Button moveToAnotherFragmentButton; private Button moveBackButton;
@nullable https://github.com/nullable @override https://github.com/override public View onCreateView(final LayoutInflater inflater, @nullable https://github.com/nullable final ViewGroup container, @nullable https://github.com/nullable final Bundle savedInstanceState) { final View rootFragmentView = inflater.inflate(R.layout.first_fragment, container, false); moveToAnotherFragmentButton = (Button) rootFragmentView.findViewById(R.id.first_fragment_go_to_another_fragment_button); moveBackButton = (Button) rootFragmentView.findViewById(R.id.first_fragment_back_button); return rootFragmentView; }
@override https://github.com/override public void onViewCreated(@nonnull https://github.com/nonnull final View view, @nullable https://github.com/nullable final Bundle savedInstanceState) { super.onViewCreated(view, savedInstanceState);
moveToAnotherFragmentButton.setOnClickListener(ignored -> addToStack(FirstFragment.class)); moveBackButton.setOnClickListener(ignored -> getFragmentManager().popBackStack());
}
@override https://github.com/override @nonnull https://github.com/nonnull public FirstFragmentPresenter createPresenter() { Log.e(TAG, "createPresenter"); return new FirstFragmentPresenter(); }
@nonnull https://github.com/nonnull @override https://github.com/override public FirstFragmentViewState createViewState() { Log.e(TAG, "createViewState"); return new FirstFragmentViewState(); }
@override https://github.com/override public void onNewViewStateInstance() { Log.e(TAG, "onNewViewStateInstance"); }
private void addToStack(@nonnull https://github.com/nonnull final Class<? extends Fragment> fragmentClass) { final FragmentManager fragmentManager = getFragmentManager(); if (fragmentManager.isDestroyed()) { throw new UnexpectedException("FragmentManager is destroyed"); }
final Fragment fragment = Fragment.instantiate(getContext(), fragmentClass.getName());
final FragmentTransaction fragmentTransaction = fragmentManager.beginTransaction(); fragmentTransaction.setTransition(FragmentTransaction.TRANSIT_FRAGMENT_OPEN);
fragmentTransaction.replace(R.id.activity_main_content_container, fragment, null) .addToBackStack(null) .commit();
} }`
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sockeqwe/mosby/issues/265, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjnrqWkiiJ1hwzpaxkglNXcPdQ1lCPxks5sPb3MgaJpZM4OcZK- .
contrudar
Thomas-Vos
Hello, I discribed the problem on stackoverflow first, but didn't get the response so far. So, ask my question here.
When we do popBackStack and return to the previous fragment in the back stack, the bundle in the method onViewCreated(View view, Bundle bundle) is always null due to the fact that onSaveInstanceState(Bundle outState) wasn't called before. So, when we go back, bundle is null and a presenter (and view state) is created again. How in this case we can reuse presenter and view state (and not recreate it)?
You can see a dummy example below. There is a fragment with 2 buttons. One button opens a new Fragment and another button goes to the previous one. When you go back, presenter and view states are recreated. That's not I need, but I described above why it's happenning according to the code in the library. Is there a way to ensure that we reuse presenter and view state when we go back?