sockeqwe
commented
6 years ago Hm, seems you have implemented it correctly. You have to do the dependency injection in onCreate() BEFORE calling super.onCreate() which you did.
I think the problem is the following: If you inject into your own presenter variable (I explicitly say own variable, because Mosby internally already has a presenter variable too), you also have to override getPresenter() and setPresenter() of MvpActivity(). Please try to add this two methods.
j2emanue notifications@github.com schrieb am Fr., 22. Dez. 2017, 10:13:
i was successfully using mosby2 for a long time now and changed to mosby3. at runtime the presenter cannot be created. Tested on Oreo api 26 emulator xxhdpi.
Here are the dependencies:
implementation 'com.hannesdorfmann.mosby3:mvp:3.1.0' // Plain MVP implementation 'com.hannesdorfmann.mosby3:viewstate:3.1.0' // MVP + ViewState support
If i do the following which is creating the presenter without dependency injection there is no issue: @nonnull https://github.com/nonnull @override https://github.com/override public WelcomePresenter createPresenter() { return new WelcomePresenter(); }
but the following gives a NPE when using dagger2 in android:
public class AuthenticationActivity extends MyappBaseMvpActivity<AuthenticationView, AuthenticationPresenter> implements AuthenticationView {
@Inject AuthenticationPresenter presenter; //confirmed this value is not null @Override protected void onCreate(Bundle savedInstanceState) { ((MyappApplication) getApplicationContext()).getAppComponent().inject(this); //injecting presenter which works in Mosby2 super.onCreate(savedInstanceState); setContentView(R.layout.activity_authentication); ButterKnife.bind(this); presenter.loadScreen(); //blah blah }@NonNull @Override public AuthenticationPresenter createPresenter() { return presenter; //confirmed through debugger this value is NOT null } }
Here is what i have tried: moving the " ((MyAppApplication) getApplicationContext()).getAppComponent().inject(this);" call after the super call and even after setnContentView. Same issues.
Here is the exact error i recieve :
FATAL EXCEPTION: main Process: com.mobile.myapp.labs, PID: 2680 java.lang.RuntimeException: Unable to start activity ComponentInfo{com.mobile.myapp.labs/com.mobile.myapp.ui.login.activities.AuthenticationActivity}: java.lang.NullPointerException: Presenter returned from createPresenter() is null. Activity is com.mobile.myapp.ui.login.activities.AuthenticationActivity@8ba807c at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2817) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2892) at android.app.ActivityThread.-wrap11(Unknown Source:0) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1593) at android.os.Handler.dispatchMessage(Handler.java:105) at android.os.Looper.loop(Looper.java:164) at android.app.ActivityThread.main(ActivityThread.java:6541) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767) Caused by: java.lang.NullPointerException: Presenter returned from createPresenter() is null. Activity is com.mobile.myapp.ui.login.activities.AuthenticationActivity@8ba807c at com.hannesdorfmann.mosby3.mvp.delegate.ActivityMvpDelegateImpl.createViewIdAndCreatePresenter(ActivityMvpDelegateImpl.java:92) at com.hannesdorfmann.mosby3.mvp.delegate.ActivityMvpDelegateImpl.onCreate(ActivityMvpDelegateImpl.java:142) at com.hannesdorfmann.mosby3.mvp.MvpActivity.onCreate(MvpActivity.java:42) at com.mobile.myapp.ui.base.MyappBaseMvpActivity.onCreate(MyappBaseMvpActivity.java:88) at com.mobile.myapp.ui.login.activities.AuthenticationActivity.onCreate(AuthenticationActivity.java:56) at android.app.Activity.performCreate(Activity.java:6975) at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1213) at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2770) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2892) at android.app.ActivityThread.-wrap11(Unknown Source:0) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1593) at android.os.Handler.dispatchMessage(Handler.java:105) at android.os.Looper.loop(Looper.java:164) at android.app.ActivityThread.main(ActivityThread.java:6541) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767) 12-22 08:58:10.863 1811-1823/system_process E/memtrack: Couldn't load memtrack module
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sockeqwe/mosby/issues/298, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjnriuP1IgcidmF-zwKwfHUeaxBEHASks5tC3LPgaJpZM4RK0GO .
j2emanue
jshvarts
lebeshev
pawelnbd1992
leslieam
engi2nee
i was successfully using mosby2 for a long time now and changed to mosby3. at runtime the presenter cannot be created. Tested on Oreo api 26 emulator xxhdpi.
Here are the dependencies:
implementation 'com.hannesdorfmann.mosby3:mvp:3.1.0' // Plain MVP implementation 'com.hannesdorfmann.mosby3:viewstate:3.1.0' // MVP + ViewState support
If i do the following which is creating the presenter without dependency injection there is no issue: @NonNull @Override public WelcomePresenter createPresenter() { return new WelcomePresenter(); }
but the following gives a NPE when using dagger2 in android:
Here is what i have tried: moving the " ((MyAppApplication) getApplicationContext()).getAppComponent().inject(this);" call after the super call and even after setnContentView. Same issues.
Here is the exact error i recieve :