sockeqwe / sqlbrite-dao

DAO for SQLBrite
http://hannesdorfmann.com/android/sqlbrite-dao
Apache License 2.0
182 stars 22 forks source link

An option for selecting all columns #12

Closed ghost closed 9 years ago

ghost commented 9 years ago

In the SELECT(String... columns) it will be better if no arguments are accounted to all columns instead of throwing an exception, writing all column names can get tedious will be happy to do a PR for this

sockeqwe commented 9 years ago

I think it's good practice to only specify which columns you want to read to reduce the amount of loaded data.

Nevertheless, you can write SELECT("*") which is mor expressive since you know what "*" means

ghost commented 9 years ago

agrees, that works with the current logic as well added a javadoc comment to make this more obvious

13

sockeqwe commented 9 years ago

thanks!