sockethub / sockethub

A multi-protocol gateway for the Web using ActivityStream messages.
http://sockethub.org
GNU Lesser General Public License v3.0
381 stars 46 forks source link

AS2.0 names not working for IRC platform #646

Closed galfert closed 2 years ago

galfert commented 2 years ago

The name changes introduced #574 don't seem to work for the IRC platform yet.

E.g. I received the following message, which still contains @type, @id and displayName.

{
    "actor": {
        "@type": "person",
        "@id": "wubbalubbadubdub@irc.libera.chat",
        "displayName": "wubbalubbadubdub"
    },
    "target": {
        "@type": "room",
        "@id": "irc.libera.chat/#kosmos",
        "displayName": "#kosmos"
    },
    "object": {
        "role": "member",
        "type": "presence"
    },
    "published": "1639411352558",
    "context": "irc",
    "type": "update"
}
silverbucket commented 2 years ago

@galfert Hmm, this is really odd, because there is no instance of @id in the IRC platform code.

Are you using an npm installed sockethub-platform-irc module or did you run yarn install from the sockethub root (which uses bootstrap to link local packages together)?

galfert commented 2 years ago

I ran yarn install and yarn run build, just to be sure.

galfert commented 2 years ago

You can try https://github.com/67P/hyperchannel/pull/259 to see if it happens for you as well. The Browser console shows the received messages.

galfert commented 2 years ago

@silverbucket the irc2as package seems to still contain the old names.