search

socketio / engine.io-client-java

Engine.IO Client Library for Java
http://socketio.github.io/engine.io-client-java
Other
360 stars 167 forks source link

fix https://github.com/square/okhttp/issues/2283 SecurityException #80

Closed xuduo closed 3 years ago

xuduo commented 7 years ago

fix SecurityException crash on some android devices in some circumstances.

nkzawa commented 7 years ago

Sorry for the delay, but I wonder if there is a way to reproduce the problem.

xuduo commented 7 years ago

Maybe if you don't add internet permission on androidManifest, have not tried. In my case, I have this permission on androidManifest, It's from app crash report.

xuduo commented 7 years ago

I successfully fixed this crash by using this commit

nkzawa commented 7 years ago

🤔 but basically, you'd need internet permission to use this lib, right ?

Anyway, it seems this problem would be addressable with websocketFactory option which you can set the dns settings as well.

see https://github.com/socketio/engine.io-client-java/pull/85

darrachequesne commented 3 years ago

Closed due to inactivity, please reopen if needed.