Add option to share OkHttpClient

socketio / engine.io-client-java

Engine.IO Client Library for Java

http://socketio.github.io/engine.io-client-java

Other

360 stars 167 forks source link

Add option to share OkHttpClient #82

Closed Jashepp closed 7 years ago

Jashepp commented 7 years ago

Potentially Fixes Issue #81

This adds an option to share an OkHttpClient instance over multiple sockets (from reconnect attempts, and etc). Defaults to false. Let me know if the option can be named better, or if this can be done a better way. This java-client-specific option can probably be mentioned in the readme under features?

shobhitpuri commented 7 years ago

@Unchosen Thanks so much for making the pul request? Would it be possible for you to please update the test case that's failing?

Jashepp commented 7 years ago

Odd.. In the first Travis CI tests ran on this PR, openjdk7 tests completed, yet the openjdk8 tests failed on the yeast test. Yet now the tests are passing. It may have just been something random unrelated to this PR changes.