fix: use globalThis polyfill instead of self/global

socketio / engine.io-client

The engine used in the Socket.IO JavaScript client, which manages the low-level transports such as HTTP long-polling, WebSocket and WebTransport.

https://socket.io

742 stars 356 forks source link

fix: use globalThis polyfill instead of self/global #683

Closed adeyahya closed 2 years ago

adeyahya commented 2 years ago

Note: the engine.io.js file is the generated output of make engine.io.js, and should not be manually modified.

add polyfill to fix self/global is not defined in vite or Android 8 and React

The kind of change this PR does introduce

[x] a bug fix
[ ] a new feature
[ ] an update to the documentation
[ ] a code change that improves performance
[ ] other

Current behaviour

New behaviour

Other information (e.g. related issues)

darrachequesne commented 2 years ago

1.8.x is quite an old branch (included in socket.io-client@1.7.x, circa 2017), I don't think the CI still runs (I think it was based on Travis). Any reason you are stuck with this version?

darrachequesne commented 2 years ago

Closed due to inactivity, please reopen if needed.