search

socketio / socket.io-adapter

The Socket.IO in-memory adapter
https://socket.io/
197 stars 101 forks source link

[experimental] remove hasownproperty check #46

Closed billouboq closed 4 years ago

billouboq commented 7 years ago

Not really sure about this one what do you think? Maybe we should use a map instead of an object to store sockets in future version (for this we need to drop support of nodejs 0.10, so this might be a little to soon for this) In order to work, socket.io-redis needs this PR https://github.com/socketio/socket.io-redis/pull/164

darrachequesne commented 7 years ago

Well, since nodejs 0.10 is already EOL'd, and 0.12 will be in a few days, I guess switching to a Map would make sense now (and the Room object could also be removed).

billouboq commented 7 years ago

I think a lot of people are still using node 0.10 but I'm more than happy to drop older versions.

knoxcard commented 5 years ago

I think it is time...

pdonias commented 5 years ago

Is it time yet?

pdonias commented 5 years ago

I guess it's not :cry:

darrachequesne commented 4 years ago

Let's switch to ES6 Map/Set (better late than never).

Closed by https://github.com/socketio/socket.io-adapter/commit/53ed3f4099c073546c66d911a95171adcefc524c.