search

socketio / socket.io-adapter

The Socket.IO in-memory adapter
https://socket.io/
197 stars 101 forks source link

rooms and sids are protected #63

Closed ejose19 closed 3 years ago

ejose19 commented 3 years ago

Refers to https://github.com/socketio/socket.io/issues/3697

Is there any particular reason you made those protected? If it's to not allow modifications from the outside, shouldn't we provide getRooms and getSids to act as getters? I can work on a PR if this is the approved solution.

darrachequesne commented 3 years ago

Let's make them public then: https://github.com/socketio/socket.io-adapter/commit/313c5a9fb60d913cd3a866001d67516399d8ee2f

Included in socket.io-adapter@2.1.0 & socket.io@3.1.0.