search

socketio / socket.io-adapter

The Socket.IO in-memory adapter
https://socket.io/
197 stars 101 forks source link

There seems to be a problem with the computeExceptSids method called in the apply method. #82

Closed zishang520 closed 2 years ago

zishang520 commented 2 years ago

BroadcastOptions.except is of type Set<SocketId> but computeExceptSids requires Set<Room>: https://github.com/socketio/socket.io-adapter/blob/b92d65cf9c6124930fac78349e2a0b847fe19f16/lib/index.ts#L288

BroadcastOptions.except: https://github.com/socketio/socket.io-adapter/blob/b92d65cf9c6124930fac78349e2a0b847fe19f16/lib/index.ts#L19

computeExceptSids: https://github.com/socketio/socket.io-adapter/blob/b92d65cf9c6124930fac78349e2a0b847fe19f16/lib/index.ts#L313

darrachequesne commented 2 years ago

Good catch, thanks! This should be fixed by https://github.com/socketio/socket.io-adapter/commit/3410584a9322dd07145e3dc60b892c17d46c3aeb.