search

socketio / socket.io-admin-ui

Admin UI for Socket.IO
https://admin.socket.io
MIT License
346 stars 93 forks source link

[Question] Why not Vue 3? #17

Open AnoRebel opened 3 years ago

AnoRebel commented 3 years ago

As the heading suggests, this is more of a question than an issue.

Why not use vue 3? Is it because of Vuetify(since it doesnt have a vue 3 integration yet)?

darrachequesne commented 3 years ago

That's a fair question, thanks! I think we mainly focused on Getting Things Done™, instead of checking whether all the dependencies (vuetify, chartjs) would work with Vue 3.

But we could totally migrate to Vue 3 in the future :+1:

AnoRebel commented 3 years ago

Oh, ok, cool then.. When I get time, I was thinking of creating the Vue 3 version from your code(refactor it basically). Would that be okay? I'll make a branch and a PR later after. Cant guarantee when though.

Also, I think with all the libraries used, only vuetify lacks Vue 3 support, so i'll probably use something like tailwindcss instead.

darrachequesne commented 3 years ago

@AnoRebel that would be awesome :+1:

AnoRebel commented 2 years ago

Sorry it took I while, I was kinda busy.. So the 1st iteration is at my fork on the next branch. Its not complete yet but most of it is complete. If anyone has time to test and point out stuff I missed or thats not working, would be great.

davidzwa commented 2 years ago

Just FYI: Vuetify3 is not getting released soon. We have to hold our breath for months, if it continues like this with Vuetify 3 😉 Also note that Vuetify v3.1 will take even longer and only that version is feature-complete (VDataTable or VSchedule anyone?) Once it is released, I can aid in the conversion as I maintain an app in Vuetify 3 beta as well as Vuetify 2.

This UI does not use Typescript (sadly), no vee-validate (luckily) and also not vue-class-components (luckily). That will save you lots of migration efforts! I suggest changing to Typescript and changing Vuex to Pinia. It's been really nice in Pinia so far!

My Vue2 + Vuetify2 project: https://github.com/fdm-monster/fdm-monster/tree/develop/client-vue The Vue3 + Vuetify3 + Vite project with VeeValidate, Zod and Pinia: https://github.com/fdm-monster/fdm-monster-client

You can ping me here for questions, if you like.