search

socketio / socket.io-admin-ui

Admin UI for Socket.IO
https://admin.socket.io
MIT License
354 stars 96 forks source link

Retrieve "socket.data" from sockets #32

Closed y4my4my4m closed 2 years ago

y4my4my4m commented 3 years ago

https://github.com/socketio/socket.io-admin-ui/blob/main/lib/index.ts#L338-L366

Why is data not included? All custom data are added to socket.data since v4 I believe.

darrachequesne commented 3 years ago

The socket.data is indeed missing. Could you please open a PR for this?

y4my4my4m commented 3 years ago

@darrachequesne will do

y4my4my4m commented 2 years ago

@darrachequesne I've opened a PR on this matter a while back but I'm stomped, can't seem to make it work.

Could you take a look? https://github.com/socketio/socket.io-admin-ui/pull/34

Cheers

darrachequesne commented 2 years ago

This was implemented in https://github.com/socketio/socket.io-admin-ui/commit/3773fe4b1cbf2206708e1f21ce65f430a522527f and included in version 0.3.0:

Peek 2022-05-03 07-44