search

socketio / socket.io-admin-ui

Admin UI for Socket.IO
https://admin.socket.io
MIT License
358 stars 95 forks source link

Add socket.data #34

Closed y4my4my4m closed 2 years ago

y4my4my4m commented 3 years ago

Issue

Description

Currently doesn't work.

Argument of type 
'import("/usr/src/node/node_modules/socket.io/dist/index").Server<import("/usr/src/node/node_modules/socket.io/dist/typed-events").DefaultEventsMap, import("/usr/src/node/node_modules/socket.io/dist/typed-events").DefaultEventsMap, import("/usr/src/node/node_modules/socket.io/dist/typed-events").DefaultEventsMap>' is not assignable to parameter of type 'import("/usr/src/node/admin-ui/socket.io-admin-ui/node_modules/socket.io/dist/index").Server<import("/usr/src/node/admin-ui/socket.io-admin-ui/node_modules/socket.io/dist/typed-events").DefaultEventsMap, import("/usr/src/node/admin-ui/socket.io-admin-ui/node_modules/socket.io/dist/typed-events").DefaultEventsMap, im..

I'm assuming it's because socket.io-admin-ui compares typed-event with socket.io's typed-event and they don't match, but if data is not readable on socket.io, I'm probably going about this the wrong way.

@darrachequesne any insight at what I'm doing wrong?

Details

Currently I'm using the local module by editing my package.json like this:

  "dependencies": {
    "@socket.io/admin-ui": "file:admin-ui/socket.io-admin-ui", //use your local folder's relative path here
vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/socketio/socket-io-admin-ui/4WbsjzZjs6BC5UFjn1BqB8CoM4SZ
✅ Preview: https://socket-io-admin-ui-git-fork-y4my4my4m-socket-data-socketio1.vercel.app

y4my4my4m commented 2 years ago

Closed in favor of https://github.com/socketio/socket.io-admin-ui/pull/37