socketio / socket.io-client-swift

Other
5.21k stars 841 forks source link

support for iOS 13 devices #1237

Open shivamsharma-1996 opened 4 years ago

shivamsharma-1996 commented 4 years ago

iOS Apps build upon Xcode 11 for iOS 13 support need to use swift 5.1 version. As Socket.IO was last upgraded to swift 5.0, so are not compatible to compile with swift 5.1 compiler.

nuclearace commented 4 years ago

I would think it would still compile, even on Swift 5.1. IIRC there hasn't been any breaking Swift changes that would affect this lib.

shivamsharma-1996 commented 4 years ago

@nuclearace It means you are just expecting .. You dnt have tested this thing?

please check following issues and get back to me please. https://forums.developer.apple.com/thread/117635 https://github.com/AudioKit/AudioKit/issues/1860

nuclearace commented 4 years ago

I did a build for ios 13, yes. That is talking about already compiled modules, which won't work. You need to rebuild the framework with the new version of the compiler.

shivamsharma-1996 commented 4 years ago

@nuclearace Actually socket.IO framework is compiled with swift 5.0 compiler and I'm trying to compile it with swift 5.1 compiler under Xcode 11.

Reason behind to migrate my project on swift 5.1(which is only supported by xcode11) is to add support for iOS 13 devices also. iOS 13 devices supports the apps written in swift 5.1

shivamsharma-1996 commented 4 years ago

I did a build for ios 13, yes. That is talking about already compiled modules, which won't work. You need to rebuild the framework with the new version of the compiler.

It means we need socket.io to compile with swift 5.1 compiler to be able to give support for iOS 13 devices?

nuclearace commented 4 years ago

It means we need socket.io to compile with swift 5.1 compiler to be able to give support for iOS 13 devices?

Yes. I was able to do a pod update on my test project and build for iOS 13 without a problem.

shivamsharma-1996 commented 4 years ago

It means we need socket.io to compile with swift 5.1 compiler to be able to give support for iOS 13 devices?

Yes. I was able to do a pod update on my test project and build for iOS 13 without a problem.

nuclearace commented 4 years ago

Yes,. my test project is using the framework (installed through CocoaPods) and using Xcode 11.1.

Screen Shot 2019-10-17 at 8 15 44 AM
shivamsharma-1996 commented 4 years ago

Yes you're right. You've used cocoapods.

Actually I've created a framework for VoIP calling in which I'm using Socket.io & Starscream frameworks which have installed without any Package manager(like cocoapods) . Instead I used socket.io using following command : $ git submodule add https://github.com/socketio/socket.io-client-swift.git

Now need to release support for iOS 13 devices. but facing problem with existing socket.io which is installed w/o using package manager.

So can you tell me how it can be resolve?

shivamsharma-1996 commented 4 years ago

Yes,. my test project is using the framework (installed through CocoaPods) and using Xcode 11.1.

Screen Shot 2019-10-17 at 8 15 44 AM

Can you make sure you don't have used any toolchain inside xcode 11 to use swift 5.0 Also Can you send me the screenshot of swift compiler from target's build settings.

nuclearace commented 4 years ago

I recreated the project this time, still same result.

Screen Shot 2019-10-17 at 9 15 41 AM