search

socketio / socket.io-client-swift

Other
5.21k stars 839 forks source link

fix never running timingOut due to weak self capture #1463

Closed davidkessler-ch closed 9 months ago

davidkessler-ch commented 9 months ago

Refer to: this issue

Fixed [the timeOut callback function never running] by removing the weak self capture in the timingOut function. Not sure why self is lost in the first place, but retain cycles are not a problem since they are only temporary anyways with asyncAfter(...) { }

mendimr commented 1 month ago

@nuclearace Any news when this PR will be merged with main?