socketio / socket.io-client-swift

Other
5.21k stars 839 forks source link

Privacy Manifest #1469

Open EricJMoon opened 8 months ago

EricJMoon commented 8 months ago

Hi, At WWDC23 Apple announced that apps and SDKs that make use of "required reason" APIs and "Data Collection", "Tracking" will need to provide a privacy manifest. Does socket.io-client-swift need to include this manifest?

https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_data_use_in_privacy_manifests https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api

orakull commented 5 months ago

Hello! socket.io-client-swift is not in list of third-party SDKs, so Apple does not require Privacy Manifest for it. But in other side socket.io-client-swift depends on Starscream which is in this list. Fortunately last version of socket.io-client-swift has dependency Starscream (~> 4.0.6) and Starscream has been updated with MP in version 4.0.8. So you can just update like this in your project:

pod update Socket.IO-Client-Swift Starscream
batikansosun commented 4 months ago

For now, I found this solution. Just fork this and update the pod spec file. I did it. You can use the below line.

pod 'Socket.IO-Client-Swift', :git => 'https://github.com/batikansosun/socket.io-client-swift.git'

xxZap commented 3 months ago

I forked SocketIO and updated it's minimum Starscream version to successfully release my application to the App Store.

Here's the Pull Request