search

socketio / socket.io-client-swift

Other
5.21k stars 839 forks source link

Update Starscream to v4.0.8 #1487

Closed gin0606 closed 2 months ago

gin0606 commented 5 months ago

ref https://github.com/socketio/socket.io-client-swift/issues/1478

We need to update the version of Starscream to support the Privacy Manifest.

https://github.com/daltoniam/Starscream/compare/4.0.6...4.0.8

This pull request is a redo of https://github.com/socketio/socket.io-client-swift/pull/1486.

I have reconfirmed the operation, and it appears to be functioning correctly in my application( socket.io 2 servers ).

slice-varundudeja commented 4 months ago

when will this get released? its needed to remove apple warnings.

bmt2018 commented 4 months ago

With the privacy manifest deadline looming, if there isn't a new release that merges these changes for the Starscream dependency and you're using SPM, it looks like it might(?) be possible to fix this by bringing in the Socket.IO client as a local package and then editing the package.swift file to specify Starscream 4.0.8 instead of 4.0.6. I'm basing this assumption on https://developer.apple.com/documentation/xcode/editing-a-package-dependency-as-a-local-package. Has anyone tried this?

amuyu commented 4 months ago

Starscream needs to be updated because it is included in the following content. I'm curious about when it will be reflected. (cc. @nuclearace )

The following are commonly used SDKs in apps on the App Store. Starting in spring 2024, you must include the privacy manifest for any SDK listed below when you submit new apps in App Store Connect that include those SDKs https://developer.apple.com/support/third-party-SDK-requirements/

https://github.com/daltoniam/Starscream/pull/1008

cbiggin commented 4 months ago

This really does need to be updated because you've specified Exact Version (of Starscream v4.0.6) instead of Up to Next Major Version in the Package.swift. This means that I cannot even explicitly add Starscream v4.0.8 as an SPM package since it conflicts.

WestFlow127 commented 4 months ago

@nuclearace this should be added to v16.1.1

imnak0-naver commented 4 months ago

is there anyone who can approve this PR? 'o'?

EgzonArifi commented 3 months ago

any updates on this?

benjamin-es-hall commented 3 months ago

The deadline requiring privacy manifests has now past and expecting releases including socket-io to get blocked by apple unless this is done. Any update on when this will be merged and deployed?

tumata commented 2 months ago

@gin0606 Please note that updating Starscream to 4.0.8 while not also updating the podspec's s.ios.deployment_target = '12.0' leads to the following cocoapod error when building pods that rely on Socket.IO:

Socket.IO-Client-Swift/Source/SocketIO/Engine/SocketEngine.swift:27:8: error: compiling for iOS 11.0, but module 'Starscream' has a minimum deployment target of iOS 12.0

See #1488 - you can just merge that into this PR.

This is completely blocking our team...

gin0606 commented 2 months ago

The changes in https://github.com/socketio/socket.io-client-swift/pull/1492 are better, so this Pull Request is no longer necessary.