search

socketio / socket.io-client-swift

Other
5.21k stars 839 forks source link

Support Privacy Manifest: bump Starscream package version to upToNextMajor 4.0.8 #1492

Open xxZap opened 3 months ago

xxZap commented 3 months ago

This PR solves the impossibility of publishing iOS applications due to the Privacy Manifest rule which is now mandatory.

The problem is that socket.io is pointing to 4.0.6 Starscream, but Starscream started supporting the Privacy Manifest policy from 4.0.8.

This PR updates its minimum version from 4.0.6 to 4.0.8.

I already published my application to the App Store with this change without any issues.

⭐️ Eventually, instead of using upToNextMajor you can use exact. It's up to you.

9oHigh commented 2 months ago

@nuclearace Please accept PR

icepat commented 2 months ago

Would be amazing if you guys could merge this PR We have Starscream crashing in the background with WalletConnect and are hoping that the 4.0.8 will solve this.

xxZap commented 3 weeks ago

Any news about this PR? I think that it easily solves a problem that affects everyone who is using socket.io