Closed dvv closed 13 years ago
Just stop committing them, problem solved. On Jul 12, 2011, at 4:54 PM, dvv wrote:
Hi!
Please, consider pruning compilable dist files (socket.io*.js) out of version control. Those who use npm, should utilize
scripts.install
package.json feature (to be added). Those who usegit clone
should runmake build
once.This will prevent from constant merging conflicts for these files.
TIA, --Vladimir
Reply to this email directly or view it on GitHub: https://github.com/LearnBoost/socket.io-client/issues/239
Then they should be added to .gitignore in master, right?
and if noone will be committing them, why they at all need to be in repo?
No, I don't think removing is a option. The only reason you want this is to prevent merge conflicts that would be the only benefit you gain from this.. But that can easily be achieved if you only add and commit the files that you changed, not the dist files.
Doing a git add lib test
isn't that much type work.
The current reasons why we placed them in the folder is:
Also, @guille compiles them when we do another release.
1-3: "Those who use npm, should utilize scripts.install
package.json feature, which should be added" -- npm install socket.io-client
can generate the dist files upon installation, which is cleaner than relying on dist files which can be simply dated because forgotten
4-*: i'm neutral. Staring at minified file is kinda no-fun. Development file is just a merge of JS files under ../lib
Frankly, I don't see any profit off having them versioned.
Hi!
Please, consider pruning compilable dist files (socket.io*.js) out of version control. Those who use npm, should utilize
scripts.install
package.json feature (to be added). Those who usegit clone
should runmake build
once.This will prevent from constant merging conflicts for these files.
TIA, --Vladimir