search

socketio / socket.io-client

Realtime application framework (client)
https://socket.io
10.63k stars 3.04k forks source link

don't bundle dist files #239

Closed dvv closed 13 years ago

dvv commented 13 years ago

Hi!

Please, consider pruning compilable dist files (socket.io*.js) out of version control. Those who use npm, should utilize scripts.install package.json feature (to be added). Those who use git clone should run make build once.

This will prevent from constant merging conflicts for these files.

TIA, --Vladimir

3rd-Eden commented 13 years ago

Just stop committing them, problem solved. On Jul 12, 2011, at 4:54 PM, dvv wrote:

Hi!

Please, consider pruning compilable dist files (socket.io*.js) out of version control. Those who use npm, should utilize scripts.install package.json feature (to be added). Those who use git clone should run make build once.

This will prevent from constant merging conflicts for these files.

TIA, --Vladimir

Reply to this email directly or view it on GitHub: https://github.com/LearnBoost/socket.io-client/issues/239

dvv commented 13 years ago

Then they should be added to .gitignore in master, right?

dvv commented 13 years ago

and if noone will be committing them, why they at all need to be in repo?

3rd-Eden commented 13 years ago

No, I don't think removing is a option. The only reason you want this is to prevent merge conflicts that would be the only benefit you gain from this.. But that can easily be achieved if you only add and commit the files that you changed, not the dist files.

Doing a git add lib test isn't that much type work.

The current reasons why we placed them in the folder is:

  1. Socket.IO uses them for fast file serving
  2. Browserify needs a compiled version
  3. We should provide a complete build for people who don't use socket.io but a other server side flavor.
  4. .. add more here, like it's handy to watch a full file on github without having to compile it your self first to see the outcome of it

Also, @guille compiles them when we do another release.

dvv commented 13 years ago

1-3: "Those who use npm, should utilize scripts.install package.json feature, which should be added" -- npm install socket.io-client can generate the dist files upon installation, which is cleaner than relying on dist files which can be simply dated because forgotten 4-*: i'm neutral. Staring at minified file is kinda no-fun. Development file is just a merge of JS files under ../lib

Frankly, I don't see any profit off having them versioned.