search

socketio / socket.io-cluster-adapter

The Socket.IO official cluster adapter, allowing to broadcast events between several Socket.IO servers.
https://socket.io
MIT License
16 stars 9 forks source link

Dependency on socket.io-adapter@2.4.0 should be upgraded to socket.io-adapter@2.5.2 #8

Closed wvhulle closed 1 year ago

wvhulle commented 1 year ago

Hi, I think something went wrong during a recent upgrade.

The function createAdapter() from @socket.io/cluster-adapter@0.2.1 returns (nsp: any) => ClusterAdapter where ClusterAdapter extends Adapter from socket.io-adapter@2.4.0. However, server.adapter from socket.io@4.6.1 expects Adapter from socket.io-adapter@2.5.2. There are large differences between these two classes.

Type 'ClusterAdapter' is missing the following properties from type 'Adapter': _encode, persistSession, restoreSession ......
RaenonX commented 1 year ago

Having the same issue here. @darrachequesne could you advise?

Thanks for the work here btw.

darrachequesne commented 1 year ago

Done in https://github.com/socketio/socket.io-cluster-adapter/commit/15fd56e78d52aa65c5fbf412dec57ab4bdaee7cc, and included in version 0.2.2.

wvhulle commented 1 year ago

Thanks for the work! Are you the only contributor?

On Fri, 24 Mar 2023, 17:45 Damien Arrachequesne, @.***> wrote:

Closed #8 https://github.com/socketio/socket.io-cluster-adapter/issues/8 as completed.

— Reply to this email directly, view it on GitHub https://github.com/socketio/socket.io-cluster-adapter/issues/8#event-8840849633, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2VD2GSWDWEJAAGZCUH7MTW5XFS5ANCNFSM6AAAAAAVHADNNQ . You are receiving this because you authored the thread.Message ID: @.*** com>

darrachequesne commented 1 year ago

@wvhulle yes, I'm currently the only active contributor.