search

socketio / socket.io-protocol

Socket.IO Protocol specification
https://socket.io
506 stars 62 forks source link

feat: add test `should close the connection if no handshake is received` #31

Closed Totodore closed 11 months ago

Totodore commented 11 months ago

According to the socket.io protocol, a socket.io server should drop the engine.io connection if the client did not send any handshake before the connectTimeout parameter.

It also implies to set a connectTimeout parameter in the test server config that is greater than the pingInterval + pingTimeout to avoid other tests to fail.

Currently it is not tested in this test-suite and it would be nice to add it.

darrachequesne commented 11 months ago

Awesome, thanks! I've increased the value of connectTimeout, because it would make other tests fail.

Unrelated, but do you mind if I mention socketioxide here?

Totodore commented 11 months ago

It would be really nice 😄, thanks a lot

darrachequesne commented 11 months ago

@Totodore and voilà! https://socket.io/docs/v4/#server-implementations

Please ping me if you need anything.