search

socketio / socket.io-protocol

Socket.IO Protocol specification
https://socket.io
507 stars 62 forks source link

Added a check for global.Buffer before .isBuffer #4

Closed kevin-roark closed 10 years ago

kevin-roark commented 10 years ago

Need this check for the future where we remove the browserify insertion of Buffer. It is also cleaner to check, I believe.

rauchg commented 10 years ago

@kevin-roark the browserify Buffer should be gone right ?

rauchg commented 10 years ago

With https://github.com/LearnBoost/socket.io-client/blob/master/support/browserify.js#L22

kevin-roark commented 10 years ago

@guille I actually think Buffer is still in the build.

If you look at line 1238 here: https://github.com/LearnBoost/socket.io-client/blob/master/socket.io.js

There are hundreds of lines defining Buffer. Those are many bytes we should figure out how to trim!!