search

socketio / socket.io

Realtime application framework (Node.JS server)
https://socket.io
MIT License
61.09k stars 10.11k forks source link

WebSocket transport relies only on req.encrypted to determine ws/wss #362

Closed dvv closed 13 years ago

dvv commented 13 years ago

I consider the subj is way rigid. Please, consider applying https://github.com/dvv/socket.io/commit/9754f4339f43c00fafab278b9ed441ab7faa5496

It introduces an unobtrusive helper method which one could easily override to tune their setups to work with WebSocket/FlashSocket

TIA, --Vladimir

3rd-Eden commented 13 years ago

Had another user yesterday with the same issue.

So a fix for this is welcome addition, making it as feature request.

dvv commented 13 years ago

( sure another user is not another @dvv's alias? :) )

3rd-Eden commented 13 years ago

Nope! Unless... you had internet access during your vacation

dvv commented 13 years ago

I didn't. What's wrong with commit i linked in the topmost post? Wouldn't you take it to your fork (mine is dated and time is needed to drill down back to the code gently) and make a pull request?

3rd-Eden commented 13 years ago

@dvv there where / are bigger issues to fix, so this is kinda low priority (for me)

rauchg commented 13 years ago

In any case, this should be a property of Transport, not just Websocket