search

socketry / async-dns

An asynchronous DNS resolver and server.
MIT License
96 stars 14 forks source link

Invalid logger line #17

Closed mperham closed 2 years ago

mperham commented 3 years ago

https://github.com/socketry/async-dns/blob/3cb580150619da2a32d4939368217abf6de9fb82/lib/async/dns/handler.rb#L62

                |   ArgumentError: wrong number of arguments (given 2, expected 0..1)
                |   → /usr/lib/ruby/2.7.0/logger.rb:545 in `error'
                |     /var/lib/gems/2.7.0/gems/async-dns-1.2.5/lib/async/dns/handler.rb:62 in `rescue in process_query'
                |     /var/lib/gems/2.7.0/gems/async-dns-1.2.5/lib/async/dns/handler.rb:57 in `process_query'
                |     /var/lib/gems/2.7.0/gems/async-dns-1.2.5/lib/async/dns/handler.rb:82 in `respond'
                |     /var/lib/gems/2.7.0/gems/async-dns-1.2.5/lib/async/dns/handler.rb:76 in `block in run'
                |     /var/lib/gems/2.7.0/gems/async-1.28.9/lib/async/task.rb:265 in `block in make_fiber'
mperham commented 3 years ago 
  RubyDNS.run_server(INTERFACES) do
    self.logger = Logger.new(STDOUT)
ioquatix commented 3 years ago

Looks like there is an incompatibility between Console::Logger and Ruby's standard Logger. We can fix this by writing it like this:

@logger.error(self) {error}