search

socketry / async-dns

An asynchronous DNS resolver and server.
MIT License
96 stars 14 forks source link

Avoid Ruby warnings #5

Closed olleolleolle closed 7 years ago

olleolleolle commented 7 years ago

This PR tries to remedy the warnings in this gem that are output in CI test runs:

/home/travis/build/socketry/async-dns/lib/async/dns/resolver.rb:100:
  warning: shadowing outer local variable - name
/home/travis/build/socketry/async-dns/lib/async/dns/resolver.rb:100:
  warning: shadowing outer local variable - resource_class
/home/travis/build/socketry/async-dns/lib/async/dns/resolver.rb:178:
  warning: shadowing outer local variable - name
/home/travis/build/socketry/async-dns/lib/async/dns/replace.rb:27:
  warning: optional boolean argument is obsoleted
coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 78.919% when pulling e67848cc2a927221b67b2827bff93a680411d0c5 on olleolleolle:fix/avoid-warnings into 026b33741dc1d21d99bc15f1f36c98e42a78bffa on socketry:master.

ioquatix commented 7 years ago

Excellent choice of variable names :)