search

socketry / async-http

MIT License
298 stars 45 forks source link

Support 2.3 #24

Closed ioquatix closed 4 years ago

ioquatix commented 4 years ago

@ganmacs More work is required to support this on 2.3

https://travis-ci.org/socketry/async-http/jobs/556300746

Can you submit a PR to protocol-http2 similar to the existing extension to add Array#sum and test? I can't even compile 2.3 locally, so if you can test it that would be great.

ioquatix commented 4 years ago

@ganmacs, do you think you can also add specs to protocol-http2 that hit the breaking cases? Even if they are simple, I can improve them, as long as we have something to prevent regressions.

ganmacs commented 4 years ago

Okay. I'll add the monkey patch for Array#sum and the test for it to protocol-http2.

ioquatix commented 4 years ago

Awesome, looking forward to getting it.