socketry / async-http

MIT License
298 stars 45 forks source link

Fix `require` in code sample in readme. #31

Closed BMorearty closed 4 years ago

BMorearty commented 4 years ago

One of the code samples doesn't run because of an incorrect require.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.08%) to 91.573% when pulling 0e1de46642686a61239ebda97bf9c8f6c544518d on BMorearty:fix-require-in-readme into 8c5858febd3b824fd4808d0e8edc7e9efc1bbb40 on socketry:master.

ioquatix commented 4 years ago

Should this actually be protocol/http/response?

BMorearty commented 4 years ago

The file structure you've got is http/protocol/response because the gem is async-http, so everything has to be under async/http, not async/protocol.

I ran the code sample this way and it worked. 🤷‍♂

ioquatix commented 4 years ago

Okay awesome thanks for your contribution!