search

socketry / async-http

MIT License
298 stars 45 forks source link

Fixed Endpoint#path #36

Closed paul closed 4 years ago

paul commented 4 years ago

Calling endpoint.path had the side-effect of mutating the original @url.path to add query params, so calling it multiple times would re-add the query params every time, resulting in paths like /example?foo=bar&bam=baz?foo=bar&bam=baz.

Fixed by duping the @url.path for the buffer var.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 91.548% when pulling ca4b1a56288f9ebfd5a44b9dffd23b8c1f398b07 on paul:patch-1 into 817302ae3becde7770595ce6048ea0afb63aab5e on socketry:master.

ioquatix commented 4 years ago

Thanks for this, fixed already :)