Change RelativeLocation to raise TooManyRedirects.

socketry / async-http

MIT License

298 stars 45 forks source link

Change RelativeLocation to raise TooManyRedirects. #38

Closed BMorearty closed 4 years ago

BMorearty commented 4 years ago

ArgumentError isn't the right error to raise when there are too many redirects because it indicates that the arguments passed to a method call are wrong.

This is a breaking change. It changes the contract with callers.

coveralls commented 4 years ago

Coverage decreased (-0.3%) to 91.256% when pulling a5587f06e079d7055e352bc883a5c69068e18897 on BMorearty:morearty-fix-argumenterror into 817302ae3becde7770595ce6048ea0afb63aab5e on socketry:master.

ioquatix commented 4 years ago

That makes complete sense.