Example using async/http/internet/instance

trevorturk commented 3 years ago

Description

Documentation re: https://github.com/socketry/async-http/issues/69
Note I just added a standalone example without changing the others. I think this is appropriate since this isn't necessarily recommended for all use cases and requires an additional gem.
Note I didn't mention that you don't need to call internet&.close in an ensure block, since I think that's implied, but perhaps it's worth mentioning.
Apologies re: the whitespace changes. Please let me know if you'd like me to resubmit with a smaller diff.

Types of Changes

Documentation

Testing

N/A

ioquatix commented 3 years ago

Thanks, this looks good to me, please submit a smaller diff :p

trevorturk commented 3 years ago

Diff reduced! (But you should totally consider removing trailing whitespace some time in the future 😬 !)

ioquatix commented 3 years ago

I like to have my leading white space at the same indentation level as the rest of the code, it just looks tidier to me. Otherwise you need an editor capable of recognising the indentation level and automatically inserting it. Trailing whitespace on the other hand normally should be removed, except when it's sometime structural (e.g. in the license text).

socketry / async-http