socketry / async-io

Concurrent wrappers for native Ruby IO & Sockets.
MIT License
209 stars 28 forks source link

gems.rb: Conditionally install bake-modernize (not on JRuby). #52

Closed olleolleolle closed 3 years ago

olleolleolle commented 3 years ago

Description

CI fails, this PR attempts to make the build fail instead of error out. JRuby-related.

This fixes #45.

Types of Changes

Testing

I ran the CI, and noted that it now runs-but-fails, as opposed to erroring out.

olleolleolle commented 3 years ago
Async::Container::Threaded
  behaves like Async::IO::SharedEndpoint
Error: The action has timed out.

This test consistently times out.

RSpec.describe Async::Container::Threaded, if: RUBY_PLATFORM !~ /darwin/ do
    it_behaves_like Async::IO::SharedEndpoint, described_class
end

Perhaps we can skip on JRuby, too?

Update: skipping on JRuby made another test be "where it times out":

Async::IO::Socket
  basic udp server
Error: The action has timed out.
ioquatix commented 3 years ago

Thanks.