socketry / async-io

Concurrent wrappers for native Ruby IO & Sockets.

MIT License

209 stars 28 forks source link

Closed fallwith closed 10 months ago

fallwith commented 10 months ago

72's use of `array[..n]`:

return @read_buffer[..([size, @read_buffer.size].min - 1)]

won't work with Rubies older than 2.7.

We'll need to either refactor to support Ruby 2.5 and 2.6, or bump the required_ruby_version value in asycn-io.gemspec accordingly.

ioquatix commented 10 months ago

Ah sorry about that. I’ll bump the minimum supported version in the gemspec.

ioquatix commented 10 months ago

Okay, it was an easy fix to restore compatibility, so I've done that.

ioquatix commented 10 months ago

Sorry, messed up the cross referencing. This was fixed in https://github.com/socketry/async-io/pull/75.