search

socketry / async-redis

MIT License
83 stars 18 forks source link

Retire disconnected resources from the pool #24

Closed davidor closed 4 years ago

davidor commented 4 years ago

Fixes #23

@ioquatix I think the fix that you applied in https://github.com/socketry/async-redis/commit/7496404e8410b60cefbe72fab0c5c5ca0b3ba6b8 is incomplete.

If we don't retire the connections, .close() is never called and the connections will be there in CLOSE_WAIT until the program exits.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 125

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/async/redis/pool.rb 3 4 75.0%
<!-- Total: 3 4 75.0% -->
Totals Coverage Status
Change from base Build 124: -0.3%
Covered Lines: 220
Relevant Lines: 245
💛 - Coveralls
ioquatix commented 4 years ago

Yes you are right. Thanks for catching it.