Add support for redis `PSUBSCRIBE` command

socketry / async-redis

MIT License

83 stars 18 forks source link

Add support for redis `PSUBSCRIBE` command #25

Closed pavelgnom closed 4 years ago

pavelgnom commented 4 years ago

https://redis.io/commands/psubscribe

Added support to subscribe on a channel using pattern.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 130

25 of 25 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.0%) to 92.308%

Totals
Change from base Build 129:	1.0%
Covered Lines:	204
Relevant Lines:	221

💛 - Coveralls

ioquatix commented 4 years ago

Sorry, I missed this one. I will review.

ioquatix commented 4 years ago

Since this is almost identical to subscribe, do you think it would make sense to make it a subclass? Just wondering if we need to introduce a new surface area for something which is almost the same.