search

socketry / async-redis

MIT License
83 stars 18 forks source link

Bump protocol-redis version number #26

Closed sailor closed 4 years ago

sailor commented 4 years ago

Could be cool to release the latest improvements of the protocol-redis library in v0.4.2.

ioquatix commented 4 years ago

Is this necessary? Can’t you just bundle update?

sailor commented 4 years ago

That's what i tried at first place but it doesn't pull the latest modifications of the protocol-redis gem.

So i tried to force the version of this gem in my gemspec 

  spec.add_dependency 'protocol-redis', '~> 0.3.1'
  spec.add_dependency 'async-redis', '~> 0.4'

But i got the following errors:

  In Gemfile:
    quiq was resolved to 0.1.0, which depends on
      async-redis (~> 0.4) was resolved to 0.4.1, which depends on
        protocol-redis (~> 0.2.0)

    quiq was resolved to 0.1.0, which depends on
      protocol-redis (~> 0.3.1)
ioquatix commented 4 years ago

I see, let me take a look, it's trying to use ~> 0.2.0 for some reason.

ioquatix commented 4 years ago

Okay, I didn't release the latest master yet. I will do it now. It should solve this issue.

sailor commented 4 years ago

Thank you very much :-)

ioquatix commented 4 years ago

It was fixed in v0.4.2 can you please try it and report back.

sailor commented 4 years ago

It works, thank's!