Friendly client wrapper with SSL, AUTH and db SELECT

socketry / async-redis

MIT License

83 stars 18 forks source link

Friendly client wrapper with SSL, AUTH and db SELECT #36

Closed troex closed 3 years ago

troex commented 3 years ago

Description

Just a friendly example of client connection wrapper, could save couple of hours for people trying to do essential setup with gem

Types of Changes

Example

Testing

[ ] I added tests for my changes.
[*] I tested my changes locally.
[ ] I tested my changes in staging.
[ ] I tested my changes in production.

olleolleolle commented 3 years ago

Perhaps the comments about SSL options after the method declaration in the wrapper is a bit TODO? I read it as such, at least.

Examples are a good thing, though, so I welcome iteration on this cool addition.

ioquatix commented 3 years ago

The SSL params are already documented as part of the OpenSSL gem, so we should just defer to set_params documentation, I think the main contribution is the overall structure so I'm fine with it as is. But feel free to make it more friendly/easy for users! Thanks everyone.