search

socketry / async-redis

MIT License
83 stars 18 forks source link

Context::Pipeline#collect requires useless block #39

Closed orlando-labs closed 1 week ago

orlando-labs commented 2 years ago

Hi, I found out Context::Pipeline#collect requires block: https://github.com/socketry/async-redis/blob/da5a38cef1b84463f9374bab076006b88fa9a811/lib/async/redis/context/pipeline.rb#L93

What's the purpose of this yield? It does nothing but just the block execution.

ioquatix commented 2 years ago

Derp, that seems like a bug.

ioquatix commented 1 week ago

I'm admiring how long it took me to circle back to this. I've fixed it and added a test. Sorry about the wait.