Improve validation of Websocket requests - Githubissues

socketry / async-websocket

Asynchronous WebSocket client and server, supporting HTTP/1 and HTTP/2 for Ruby.

MIT License

166 stars 18 forks source link

Improve validation of Websocket requests #59

Closed zarqman closed 8 months ago

zarqman commented 11 months ago

This PR improves the validation of Websocket requests to:

Verify response.protocol (aka Upgrade) for h11
Verify Connection for h11

It also adds tests for the existing verification of response.status for both h11 and h2.

This is based on RFC 6455, page 19, items 2 (Upgrade) and 3 (Connection).

Types of Changes

Performance improvement.

Contribution

[x] I added tests for my changes.
[x] I tested my changes locally.
[x] I agree to the Developer's Certificate of Origin 1.1.