socketry / async-websocket

Asynchronous WebSocket client and server, supporting HTTP/1 and HTTP/2 for Ruby.
MIT License
167 stars 18 forks source link

add support for sec-websocket-protocol options #6

Closed destructobeam closed 5 years ago

destructobeam commented 5 years ago

As discussed in issue #1, add support for options to Async::WebSocket::Server.open

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 45


Totals Coverage Status
Change from base Build 44: 0.0%
Covered Lines: 45
Relevant Lines: 66

💛 - Coveralls
ioquatix commented 5 years ago

I will merge and review.

ioquatix commented 9 months ago

@destructobeam thanks for your contribution.

I'd like to correctly attribute this in the relevant source files, copyright and license.

Are you able to provide me your full name that I can use in those documents? Thanks!

In other words, can you add yourself to .mailmap or provide enough detail so I can do so.