Add: Add Task#inspect - Githubissues

socketry / async

An awesome asynchronous event-driven reactor for Ruby.

MIT License

2.1k stars 86 forks source link

Add: Add Task#inspect #122

Closed sevenc-nanashi closed 3 years ago

sevenc-nanashi commented 3 years ago

Description

Task#inspect is so long like:

So I made them short.

Types of Changes

New feature.

Testing

[ ] I added tests for my changes.
[x] I tested my changes locally.
[ ] I tested my changes in staging.
[ ] I tested my changes in production.

bruno- commented 3 years ago

I can confirm inspecting Async object's status has sometimes been a struggle for me too.

ioquatix commented 3 years ago

I agree with your assessment, and I already changed it a few weeks ago on main branch. Can you check it?

ioquatix commented 3 years ago

https://github.com/socketry/async/blob/7801c07cf46de8cea50ca7a0e3dc0889722de84b/lib/async/node.rb#L220-L240

I don't think this was backported to stable-v1 which we could do.

bruno- commented 3 years ago

Sorry for the wait. I checked this and can confirm that main branch currently contains everything this PR proposes - and more.

Task#to_s also has @status

https://github.com/socketry/async/blob/731e93bca067a8ee20023bf52e992657120a7500/lib/async/task.rb#L86-L88

So, I think this PR can be closed as this feature is already implemented.

I don't think this was backported to stable-v1 which we could do.

I personally can live without this knowing there is an upgrade path.

ioquatix commented 3 years ago

I'll consider back porting it. There is a lot I want to do in this space - I want to move fiber/task annotations directly into Fiber and Thread, but this will take some time.